From reviews-return-32063-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 22 19:31:56 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A510A197E4 for ; Fri, 22 Apr 2016 19:31:56 +0000 (UTC) Received: (qmail 47423 invoked by uid 500); 22 Apr 2016 19:31:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47394 invoked by uid 500); 22 Apr 2016 19:31:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47381 invoked by uid 99); 22 Apr 2016 19:31:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 19:31:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E091D2B12EC; Fri, 22 Apr 2016 19:31:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0002496475969429884==" MIME-Version: 1.0 Subject: Re: Review Request 46504: Constructed error string in MethodNotAllowed. From: Alexander Rukletsov To: Alexander Rukletsov Cc: Jacob Janco , mesos Date: Fri, 22 Apr 2016 19:31:51 -0000 Message-ID: <20160422193151.8130.71289@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46504/ X-Sender: Alexander Rukletsov References: <20160422151133.8129.57954@reviews.apache.org> In-Reply-To: <20160422151133.8129.57954@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============0002496475969429884== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46504/#review130103 ----------------------------------------------------------- For posterity, could you please explain a bit in the description what you intention here is and why you take this implemntation approach? 3rdparty/libprocess/include/process/http.hpp (lines 569 - 571) We usually insert two blank lines here. 3rdparty/libprocess/include/process/http.hpp (line 571) Does it make sense to declare this struct inside `MethodNotAllowed`? 3rdparty/libprocess/include/process/http.hpp (lines 573 - 574) It looks like you don't need to keep this two valus as fields, right? 3rdparty/libprocess/include/process/http.hpp (line 579) Why do you take `Request` instead of a method? 3rdparty/libprocess/include/process/http.hpp (lines 603 - 605) We usually insert two blank lines here. 3rdparty/libprocess/include/process/http.hpp (lines 623 - 624) Blank line, please! 3rdparty/libprocess/include/process/http.hpp Why have you removed this line? - Alexander Rukletsov On April 22, 2016, 3:11 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46504/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 3:11 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-4126 > https://issues.apache.org/jira/browse/MESOS-4126 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 > > Diff: https://reviews.apache.org/r/46504/diff/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > > --===============0002496475969429884==--