From reviews-return-31650-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 19 23:35:19 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7554119A1A for ; Tue, 19 Apr 2016 23:35:19 +0000 (UTC) Received: (qmail 13634 invoked by uid 500); 19 Apr 2016 23:35:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 13604 invoked by uid 500); 19 Apr 2016 23:35:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 13584 invoked by uid 99); 19 Apr 2016 23:35:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 23:35:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F0C5A2B1384; Tue, 19 Apr 2016 23:35:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9117008760627758084==" MIME-Version: 1.0 Subject: Review Request 46418: Refactored the `os::access` function between POSIX and Windows. From: Michael Park To: Daniel Pravat , Joris Van Remoortere , Alex Clemmer Cc: Michael Park , mesos Date: Tue, 19 Apr 2016 23:35:14 -0000 Message-ID: <20160419233514.8135.50888@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46418/ X-Sender: Michael Park X-ReviewBoard-Diff-For: 3rdparty/libprocess/3rdparty/stout/include/stout/os/access.hpp Reply-To: Michael Park X-ReviewRequest-Repository: mesos --===============9117008760627758084== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/ ----------------------------------------------------------- Review request for mesos, Daniel Pravat, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-5237 https://issues.apache.org/jira/browse/MESOS-5237 Repository: mesos Description ------- See summary. Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp a81086860a17bd1912e55051dd7bb98a20772b51 3rdparty/libprocess/3rdparty/stout/include/stout/os/access.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f1584d0786ee0236a0e703d4aa9532e138ad49f0 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 37ef33257830e32875500537df7af38757c6efac Diff: https://reviews.apache.org/r/46418/diff/ Testing ------- `make check` Thanks, Michael Park --===============9117008760627758084==--