From reviews-return-31643-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 19 22:33:26 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC0E51974A for ; Tue, 19 Apr 2016 22:33:26 +0000 (UTC) Received: (qmail 70632 invoked by uid 500); 19 Apr 2016 22:33:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70612 invoked by uid 500); 19 Apr 2016 22:33:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70590 invoked by uid 99); 19 Apr 2016 22:33:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 22:33:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F1F122B17D9; Tue, 19 Apr 2016 22:33:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6714055974827850263==" MIME-Version: 1.0 Subject: Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test. From: Michael Park To: Joris Van Remoortere , Artem Harutyunyan , Michael Park , Alex Clemmer Cc: Daniel Pravat , mesos Date: Tue, 19 Apr 2016 22:33:21 -0000 Message-ID: <20160419223321.8130.11981@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46293/ X-Sender: Michael Park References: <20160416002052.21369.13658@reviews.apache.org> In-Reply-To: <20160416002052.21369.13658@reviews.apache.org> Reply-To: Michael Park X-ReviewRequest-Repository: mesos --===============6714055974827850263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/#review129637 ----------------------------------------------------------- 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 63) Shouldn't this be `Try`? Here and below. 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 65) Please use `ASSERT_TRUE` instead. 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 66 - 68) This fits in one line. 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 83) We should be looking at `result.error().code`. Here and below. - Michael Park On April 16, 2016, 12:20 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46293/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 12:20 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: [3/3] Updated `sendfile` test. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a > > Diff: https://reviews.apache.org/r/46293/diff/ > > > Testing > ------- > > OSX: make check > > > Thanks, > > Daniel Pravat > > --===============6714055974827850263==--