From reviews-return-31099-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 14 05:20:11 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 578E51976A for ; Thu, 14 Apr 2016 05:20:11 +0000 (UTC) Received: (qmail 91851 invoked by uid 500); 14 Apr 2016 05:20:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91822 invoked by uid 500); 14 Apr 2016 05:20:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91807 invoked by uid 99); 14 Apr 2016 05:20:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2016 05:20:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E59252B0394; Thu, 14 Apr 2016 05:20:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0885031070757876024==" MIME-Version: 1.0 Subject: Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API. From: Qian Zhang To: Anand Mazumdar , Vinod Kone Cc: mesos , haosdent huang , Qian Zhang Date: Thu, 14 Apr 2016 05:20:06 -0000 Message-ID: <20160414052006.29094.10513@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44424/ X-Sender: Qian Zhang References: <20160412202445.21369.12162@reviews.apache.org> In-Reply-To: <20160412202445.21369.12162@reviews.apache.org> X-ReviewBoard-Diff-For: src/launcher/http_command_executor.cpp Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============0885031070757876024== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 804-809 > > > > > > Lets fix this hack now that the executor receives acknowledgements for status updates. > > > > The executor can terminate after it receives an ACK for a terminal status update. Can you add a TODO here and fix it in a separate review? > > Qian Zhang wrote: > Agree, will post a separate patch for it soon. > > Qian Zhang wrote: > But what if framework does not cooperate? E.g., it does not send ACK when it receives a terminal status update from executor. Then the executor will never terminate? I think that may not be what we want ... Posted the patch: https://reviews.apache.org/r/46187/ - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review128522 ----------------------------------------------------------- On April 13, 2016, 5:13 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44424/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 5:13 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Updated http_command_executor.cpp to use v1 API. > > > Diffs > ----- > > src/launcher/http_command_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44424/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > > --===============0885031070757876024==--