From reviews-return-30678-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 11 16:40:15 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D261C19894 for ; Mon, 11 Apr 2016 16:40:15 +0000 (UTC) Received: (qmail 18532 invoked by uid 500); 11 Apr 2016 16:40:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 18506 invoked by uid 500); 11 Apr 2016 16:40:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18491 invoked by uid 99); 11 Apr 2016 16:40:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 16:40:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 242C92AF5D8; Mon, 11 Apr 2016 16:40:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2599842545212623220==" MIME-Version: 1.0 Subject: Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute. From: Alexander Rukletsov To: Anand Mazumdar , Joseph Wu Cc: Alexander Rukletsov , Guangya Liu , mesos Date: Mon, 11 Apr 2016 16:40:12 -0000 Message-ID: <20160411164012.29094.17130@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45926/ X-Sender: Alexander Rukletsov References: <20160408181013.20106.13141@reviews.apache.org> In-Reply-To: <20160408181013.20106.13141@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============2599842545212623220== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 8, 2016, 6:10 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. It's true for the _current_ code in mesos-execute, but not true for Mesos. Moreover, there is a patch in the works (https://reviews.apache.org/r/44441/) which adds support for this. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45926/#review127827 ----------------------------------------------------------- On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45926/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 12:39 p.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > > Diff: https://reviews.apache.org/r/45926/diff/ > > > Testing > ------- > > See the last patch in the chain: https://reviews.apache.org/r/45927/ > > > Thanks, > > Alexander Rukletsov > > --===============2599842545212623220==--