From reviews-return-30660-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 11 14:53:59 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8E941920F for ; Mon, 11 Apr 2016 14:53:58 +0000 (UTC) Received: (qmail 32243 invoked by uid 500); 11 Apr 2016 14:53:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32220 invoked by uid 500); 11 Apr 2016 14:53:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31960 invoked by uid 99); 11 Apr 2016 14:53:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 14:53:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 54F782AF512; Mon, 11 Apr 2016 14:53:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5744617876487250614==" MIME-Version: 1.0 Subject: Re: Review Request 46033: Removed request body from some error responses in quota handler. From: Joerg Schad To: Joerg Schad Cc: Alexander Rukletsov , mesos Date: Mon, 11 Apr 2016 14:53:55 -0000 Message-ID: <20160411145355.29093.53905@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joerg Schad X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46033/ X-Sender: Joerg Schad X-ReviewBoard-ShipIt: 1 References: <20160411144900.29094.61460@reviews.apache.org> In-Reply-To: <20160411144900.29094.61460@reviews.apache.org> Reply-To: Joerg Schad X-ReviewRequest-Repository: mesos --===============5744617876487250614== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46033/#review128127 ----------------------------------------------------------- Fix it, then Ship it! src/master/quota_handler.cpp (line 265) To be consistent with the above message (i.e. First general Failed to do ... , : , detailed error. "Failed to validate set quota request JSON: Can not set quota for role '" + quotaInfo.role() + "' that already has quota"); src/master/quota_handler.cpp (line 267) s/ already/already - Joerg Schad On April 11, 2016, 2:49 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46033/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:49 p.m.) > > > Review request for mesos and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > When an error is not related to the whole request (e.g., parsing, > converting to protobuf), but to its part (e.g., unknown role), it > seems unnecessary to include the complete request body into the > error response. > > > Diffs > ----- > > src/master/quota_handler.cpp 88247d6525b2aaeb58eea77376fd4ed8e0c653c3 > > Diff: https://reviews.apache.org/r/46033/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > > --===============5744617876487250614==--