From reviews-return-30641-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 11 13:34:04 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6EEA419F22 for ; Mon, 11 Apr 2016 13:34:04 +0000 (UTC) Received: (qmail 93776 invoked by uid 500); 11 Apr 2016 13:34:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93750 invoked by uid 500); 11 Apr 2016 13:34:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93734 invoked by uid 99); 11 Apr 2016 13:34:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 13:34:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7E4B82AF50F; Mon, 11 Apr 2016 13:34:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5511043749445418432==" MIME-Version: 1.0 Subject: Re: Review Request 45863: Updated error messages in weights handler. From: Alexander Rukletsov To: Joerg Schad , Yongqiao Wang Cc: Mesos ReviewBot , Alexander Rukletsov , mesos Date: Mon, 11 Apr 2016 13:34:00 -0000 Message-ID: <20160411133400.29094.68773@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45863/ X-Sender: Alexander Rukletsov References: <20160407110731.26225.81436@reviews.apache.org> In-Reply-To: <20160407110731.26225.81436@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============5511043749445418432== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels inconsistent here... Above are errors for the whole request, here they are per role basis. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127580 ----------------------------------------------------------- On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45863/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 10:50 a.m.) > > > Review request for mesos, Yongqiao Wang and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > While writing log or error messages we adhere the following style: > * No period at the end (there are exceptions though, e.g., one is > when constructing request responses. > * When splitting a string over multiple lines, put a space at the > beginning of the following line in contrast to the end of the > previous line. > > > Diffs > ----- > > src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e > > Diff: https://reviews.apache.org/r/45863/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `make check` > > > Thanks, > > Alexander Rukletsov > > --===============5511043749445418432==--