From reviews-return-30601-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 11 02:27:58 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16D60189FB for ; Mon, 11 Apr 2016 02:27:58 +0000 (UTC) Received: (qmail 50830 invoked by uid 500); 11 Apr 2016 02:27:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 50797 invoked by uid 500); 11 Apr 2016 02:27:57 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50779 invoked by uid 99); 11 Apr 2016 02:27:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 02:27:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 82B332AF308; Mon, 11 Apr 2016 02:27:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5654894699093345732==" MIME-Version: 1.0 Subject: Re: Review Request 45014: Add /containers endpoint. From: Jay Guo To: Jie Yu Cc: Mesos ReviewBot , Jay Guo , mesos Date: Mon, 11 Apr 2016 02:27:54 -0000 Message-ID: <20160411022754.29094.4040@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45014/ X-Sender: Jay Guo References: <20160318052732.10325.84510@reviews.apache.org> In-Reply-To: <20160318052732.10325.84510@reviews.apache.org> X-ReviewBoard-Diff-For: docs/endpoints/slave/monitor/statistics.md X-ReviewBoard-Diff-For: docs/endpoints/slave/containers.md X-ReviewBoard-Diff-For: docs/endpoints/monitor/statistics.md X-ReviewBoard-Diff-For: docs/endpoints/monitor/statistics.json.md X-ReviewBoard-Diff-For: docs/endpoints/slave/monitor/statistics.json.md Reply-To: Jay Guo X-ReviewRequest-Repository: mesos --===============5654894699093345732== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ ----------------------------------------------------------- (Updated April 11, 2016, 2:27 a.m.) Review request for mesos and Jie Yu. Summary (updated) ----------------- Add /containers endpoint. Repository: mesos Description (updated) ------- It returns both resource statistics and container status. Diffs (updated) ----- docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 docs/endpoints/slave/containers.md PRE-CREATION src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 Diff: https://reviews.apache.org/r/45014/diff/ Testing ------- make check `curl agent_ip:port/containers` returns same json content as `curl agent_ip:port/monitor/statistics.json` This is a draft patch of adding /containers endpoint to agent [MESOS-4891](https://issues.apache.org/jira/browse/MESOS-4891) ContainerStatus will be added to response based on this patch. Thanks, Jay Guo --===============5654894699093345732==--