From reviews-return-30508-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Apr 9 07:56:38 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D83319AA1 for ; Sat, 9 Apr 2016 07:56:38 +0000 (UTC) Received: (qmail 51293 invoked by uid 500); 9 Apr 2016 07:56:38 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51265 invoked by uid 500); 9 Apr 2016 07:56:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51250 invoked by uid 99); 9 Apr 2016 07:56:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Apr 2016 07:56:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 950E42ADAFE; Sat, 9 Apr 2016 07:56:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5320578679125767846==" MIME-Version: 1.0 Subject: Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API. From: Qian Zhang To: Anand Mazumdar , Vinod Kone Cc: mesos , haosdent huang , Qian Zhang Date: Sat, 09 Apr 2016 07:56:34 -0000 Message-ID: <20160409075634.26225.80870@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44424/ X-Sender: Qian Zhang References: <20160408185224.20107.34560@reviews.apache.org> In-Reply-To: <20160408185224.20107.34560@reviews.apache.org> X-ReviewBoard-Diff-For: src/launcher/http_command_executor.cpp Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============5320578679125767846== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 9, 2016, 2:52 a.m., Anand Mazumdar wrote: > > src/launcher/http_command_executor.cpp, lines 82-94 > > > > > > Let's move this all out of the `mesos::internal` namespace. We typically have `using` declarations at the top of the cpp file. > > > > Also, I synced up with Vinod offline let's put all the cpp code in `mesos::v1::internal` namespace. Then, you won't have all the naming ambiguities that made you add the using declarations in `mesos::internal` namespace. Thanks Anand! And I think we do not need the followings since we are already in `mesos::v1` namespace. using mesos::v1::CommandInfo; using mesos::v1::FrameworkInfo; using mesos::v1::KillPolicy; using mesos::v1::TaskID; using mesos::v1::TaskInfo; using mesos::v1::TaskState; using mesos::v1::TaskStatus; - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review127791 ----------------------------------------------------------- On April 7, 2016, 10:13 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44424/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 10:13 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Updated http_command_executor.cpp to use v1 API. > > > Diffs > ----- > > src/launcher/http_command_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44424/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > > --===============5320578679125767846==--