From reviews-return-30434-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 22:48:10 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D00919048 for ; Fri, 8 Apr 2016 22:48:10 +0000 (UTC) Received: (qmail 34060 invoked by uid 500); 8 Apr 2016 22:48:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34032 invoked by uid 500); 8 Apr 2016 22:48:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34016 invoked by uid 99); 8 Apr 2016 22:48:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 22:48:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 82F212AEEC3; Fri, 8 Apr 2016 22:48:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5367563891728249566==" MIME-Version: 1.0 Subject: Review Request 45956: Added the `_isolate` method. From: Avinash sridharan To: Jie Yu , Qian Zhang Cc: Avinash sridharan , mesos Date: Fri, 08 Apr 2016 22:48:06 -0000 Message-ID: <20160408224806.20106.34609@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45956/ X-Sender: Avinash sridharan Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos --===============5367563891728249566== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ ----------------------------------------------------------- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-4922 https://issues.apache.org/jira/browse/MESOS-4922 Repository: mesos Description ------- Once the `isolate` is successful, the `_isolate` method calls out the `mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and /etc/resolv.conf for the container. Diffs ----- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c Diff: https://reviews.apache.org/r/45956/diff/ Testing ------- make *Ran mesos_execute with single master/slave setup to verify that containers get the right hostname and network files when attached to a CNI network. Thanks, Avinash sridharan --===============5367563891728249566==--