From reviews-return-30425-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 22:05:51 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63D2119EC7 for ; Fri, 8 Apr 2016 22:05:51 +0000 (UTC) Received: (qmail 52141 invoked by uid 500); 8 Apr 2016 22:05:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 52114 invoked by uid 500); 8 Apr 2016 22:05:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52059 invoked by uid 99); 8 Apr 2016 22:05:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 22:05:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1EB2A2AEF05; Fri, 8 Apr 2016 22:05:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4264253406609854079==" MIME-Version: 1.0 Subject: Re: Review Request 44142: Windows: Implemented os::close for Windows. From: Daniel Pravat To: M Lawindi , Alex Naparu , Michael Park , Joris Van Remoortere , Artem Harutyunyan , Daniel Pravat , Yi Sun Cc: mesos Date: Fri, 08 Apr 2016 22:05:48 -0000 Message-ID: <20160408220548.20106.11361@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Daniel Pravat X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44142/ X-Sender: Daniel Pravat References: <20160408214003.20106.91009@reviews.apache.org> In-Reply-To: <20160408214003.20106.91009@reviews.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp Reply-To: Daniel Pravat X-ReviewRequest-Repository: mesos --===============4264253406609854079== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44142/ ----------------------------------------------------------- (Updated April 8, 2016, 10:05 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) ----------------- Windows: Implemented os::close for Windows. Repository: mesos Description (updated) ------- Windows: Implemented os::close for Windows. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d Diff: https://reviews.apache.org/r/44142/diff/ Testing ------- Thanks, Daniel Pravat --===============4264253406609854079==--