From reviews-return-30412-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 21:26:47 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 021DF19D0D for ; Fri, 8 Apr 2016 21:26:47 +0000 (UTC) Received: (qmail 48467 invoked by uid 500); 8 Apr 2016 21:26:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 48438 invoked by uid 500); 8 Apr 2016 21:26:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 48416 invoked by uid 99); 8 Apr 2016 21:26:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 21:26:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BE2422AEE85; Fri, 8 Apr 2016 21:26:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5305210102315030474==" MIME-Version: 1.0 Subject: Re: Review Request 44893: Remove fetcher header file in containerizer.hpp. From: Jie Yu To: Timothy Chen , Jie Yu , Ian Downes , Till Toenshoff , Benjamin Hindman Cc: haosdent huang , mesos Date: Fri, 08 Apr 2016 21:26:43 -0000 Message-ID: <20160408212643.26225.55551@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44893/ X-Sender: Jie Yu References: <20160403141247.20107.74803@reviews.apache.org> In-Reply-To: <20160403141247.20107.74803@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============5305210102315030474== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/#review127894 ----------------------------------------------------------- Does mesos compile after applying this patch? If not, I would rather not split the patch. Yes, we prefer smaller patches, but each of them should be an atomic change, instead of just splitting a large patch into smaller pieces. There's no point of doing that. Could you please merge those non-atomic changes into one patch? Otherwise, it's hard to reason what have you done. - Jie Yu On April 3, 2016, 2:12 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44893/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-5086 > https://issues.apache.org/jira/browse/MESOS-5086 > > > Repository: mesos > > > Description > ------- > > Remove fetcher header file in containerizer.hpp. > > > Diffs > ----- > > src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae > src/slave/containerizer/containerizer.hpp ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf > src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda > src/slave/containerizer/mesos/containerizer.hpp a6e3a8b43fb7591ff6f23b019a062696c8bfb719 > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > > Diff: https://reviews.apache.org/r/44893/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============5305210102315030474==--