From reviews-return-30405-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 21:00:21 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09DEC19BFC for ; Fri, 8 Apr 2016 21:00:21 +0000 (UTC) Received: (qmail 91470 invoked by uid 500); 8 Apr 2016 21:00:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91440 invoked by uid 500); 8 Apr 2016 21:00:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91425 invoked by uid 99); 8 Apr 2016 21:00:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 21:00:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 946332AEE40; Fri, 8 Apr 2016 21:00:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0834989974439965338==" MIME-Version: 1.0 Subject: Re: Review Request 45852: Added standard metrics for GPU resources. From: Ben Mahler To: Rob Todd , Ben Mahler , Vikrama Ditya Cc: Kevin Klues , mesos Date: Fri, 08 Apr 2016 21:00:17 -0000 Message-ID: <20160408210017.20107.11805@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ben Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45852/ X-Sender: Ben Mahler X-ReviewBoard-ShipIt: 1 References: <20160408203448.20107.88272@reviews.apache.org> In-Reply-To: <20160408203448.20107.88272@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Ben Mahler X-ReviewRequest-Repository: mesos --===============0834989974439965338== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127886 ----------------------------------------------------------- Ship it! Ship It! - Ben Mahler On April 8, 2016, 8:34 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45852/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 8:34 p.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4624 > https://issues.apache.org/jira/browse/MESOS-4624 > > > Repository: mesos > > > Description > ------- > > Added standard metrics for GPU resources. > > > Diffs > ----- > > src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 > src/slave/metrics.cpp 42c66d7d7176232ccc71f1e040bcae99900f49f8 > src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 > src/tests/slave_tests.cpp 03bb6da687a1bf11d81619839e6730835e5c4d82 > > Diff: https://reviews.apache.org/r/45852/diff/ > > > Testing > ------- > > Ran: > ``` > GTEST_FILTER="SlaveTest.MetricsInMetricsEndpoint:SlaveTest.MetricsInMetricsEndpoint" make -j check > SUCCESS > ``` > > > Thanks, > > Kevin Klues > > --===============0834989974439965338==--