From reviews-return-30401-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 20:47:53 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A326619B80 for ; Fri, 8 Apr 2016 20:47:53 +0000 (UTC) Received: (qmail 67957 invoked by uid 500); 8 Apr 2016 20:47:53 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 67928 invoked by uid 500); 8 Apr 2016 20:47:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 67912 invoked by uid 99); 8 Apr 2016 20:47:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 20:47:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6FA492AEEB8; Fri, 8 Apr 2016 20:47:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5784961381779206755==" MIME-Version: 1.0 Subject: Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource. From: Kevin Klues To: Rob Todd , Ben Mahler , Vikrama Ditya Cc: Mesos ReviewBot , Kevin Klues , haosdent huang , mesos Date: Fri, 08 Apr 2016 20:47:49 -0000 Message-ID: <20160408204749.20107.15037@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45855/ X-Sender: Kevin Klues References: <20160407021303.20106.20357@reviews.apache.org> In-Reply-To: <20160407021303.20106.20357@reviews.apache.org> Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos --===============5784961381779206755== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 7, 2016, 2:13 a.m., haosdent huang wrote: > > docs/attributes-resources.md, line 40 > > > > > > `whole number values` means `natural number` here? Whole numbers are *almost* the same as natural numbers, with one exception -- they include the number 0. We include 0, so whole nhmbers is the right term here. > On April 7, 2016, 2:13 a.m., haosdent huang wrote: > > docs/attributes-resources.md, line 99 > > > > > > How about sort it by alphabetically? The only reason I didn't sort alphabetically was because these resources don't seem to be ordered alphabetically anywhere else (`disk` always seems to come *after* `mem`). Since `gpus` are pretty similar to `cpus` in their semantics, I decided to place them next to them in the order here. We can wait to see what Ben thinks. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45855/#review127534 ----------------------------------------------------------- On April 7, 2016, 1:54 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45855/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 1:54 a.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-5135 > https://issues.apache.org/jira/browse/MESOS-5135 > > > Repository: mesos > > > Description > ------- > > Updated docs to include references to GPUs as a first class resource. > > > Diffs > ----- > > docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f > docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc > > Diff: https://reviews.apache.org/r/45855/diff/ > > > Testing > ------- > > Looked at regenerated website and it seems to include the new documentation properly. > > > Thanks, > > Kevin Klues > > --===============5784961381779206755==--