From reviews-return-30398-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 20:35:52 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4AE519B00 for ; Fri, 8 Apr 2016 20:35:52 +0000 (UTC) Received: (qmail 38861 invoked by uid 500); 8 Apr 2016 20:35:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 38833 invoked by uid 500); 8 Apr 2016 20:35:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38811 invoked by uid 99); 8 Apr 2016 20:35:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 20:35:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A44B2AEEA7; Fri, 8 Apr 2016 20:35:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4661363830632386660==" MIME-Version: 1.0 Subject: Review Request 45942: Updated the webui to include GPU metrics. From: Kevin Klues To: Kevin Klues , mesos Date: Fri, 08 Apr 2016 20:35:49 -0000 Message-ID: <20160408203549.20107.77912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45942/ X-Sender: Kevin Klues Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos --===============4661363830632386660== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45942/ ----------------------------------------------------------- Review request for mesos. Repository: mesos Description ------- Updated the webui to include GPU metrics. Diffs ----- src/webui/master/static/framework.html ee42d1ab841a4c42d95512ee60d577b1bbb66bc8 src/webui/master/static/frameworks.html 15ff1e9cb6c70df8df47a1b939681abde591e010 src/webui/master/static/home.html a691084f4992cda65734f5fee3b2f38349737b83 src/webui/master/static/js/controllers.js f92affab41f8418cd7e5ea25561a182a1761fd79 src/webui/master/static/offers.html 01213e9582f50072a9c729782271269f72972d28 src/webui/master/static/slave.html 4419f7c166e8768040dab7dbc6fb64e1382ad272 src/webui/master/static/slave_executor.html 5acb676390fe4ed17369143c5aaaaa13202c0981 src/webui/master/static/slave_framework.html 4b2b1562f38f002b4659b4a883249f0469307323 src/webui/master/static/slaves.html 0cb125a7d95ccc7770916cbffa052f43e8ea3d2c Diff: https://reviews.apache.org/r/45942/diff/ Testing ------- Manually opened the web UI, clicked around to make sure all the GPU metrics now showed up. Also looked at "Inspect Element" to verify that there were no javascript errors when loading. Specifically: ``` * The Resources section in the left sidebar of the main page * The Resources section of the table in the Frameworks tab * The Resources section of the table in the Slaves tab * The Resources section of the table in the Offers tab ``` Thanks, Kevin Klues --===============4661363830632386660==--