From reviews-return-30349-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 14:15:26 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E921A19813 for ; Fri, 8 Apr 2016 14:15:25 +0000 (UTC) Received: (qmail 13488 invoked by uid 500); 8 Apr 2016 14:15:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 13457 invoked by uid 500); 8 Apr 2016 14:15:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 13342 invoked by uid 99); 8 Apr 2016 14:15:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 14:15:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 600D11D364A; Fri, 8 Apr 2016 14:15:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8650936446561449292==" MIME-Version: 1.0 Subject: Re: Review Request 43514: Speed up MasterTest.RecoverResources. From: Alexander Rukletsov To: Ben Mahler Cc: haosdent huang , Alexander Rukletsov , mesos Date: Fri, 08 Apr 2016 14:15:19 -0000 Message-ID: <20160408141519.20106.80716@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43514/ X-Sender: Alexander Rukletsov X-ReviewBoard-ShipIt: 1 References: <20160212063637.24149.46562@reviews.apache.org> In-Reply-To: <20160212063637.24149.46562@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============8650936446561449292== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/#review127786 ----------------------------------------------------------- Fix it, then Ship it! Mind adding the description and do tests in repetition? src/tests/master_tests.cpp (line 745) I believe you do settle in order to make sure the container is destroyed. Mind writing a comment? Also, I think you can resume the clock right after advancing. - Alexander Rukletsov On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43514/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 6:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4164 > https://issues.apache.org/jira/browse/MESOS-4164 > > > Repository: mesos > > > Description > ------- > > Speed up MasterTest.RecoverResources. > > > Diffs > ----- > > src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 > > Diff: https://reviews.apache.org/r/43514/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============8650936446561449292==--