----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43329/#review127783 ----------------------------------------------------------- Fix it, then Ship it! Could you please run tests in repetition? Thanks! src/tests/master_allocator_tests.cpp (line 652) I think it's fine to do this, but let's explain why we adjust the flag. - Alexander Rukletsov On March 30, 2016, 1:22 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43329/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 1:22 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-3775 > https://issues.apache.org/jira/browse/MESOS-3775 > > > Repository: mesos > > > Description > ------- > > Speeded up MasterAllocatorTest.SlaveLost test. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 > > Diff: https://reviews.apache.org/r/43329/diff/ > > > Testing > ------- > > ``` > [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator torProcess > > [ RUN ] MasterAllocatorTest/0.SlaveLost > [ OK ] MasterAllocatorTest/0.SlaveLost (369 ms) > [----------] 1 test from MasterAllocatorTest/0 (369 ms total) > > [----------] 1 test from MasterAllocatorTest/1, where TypeParam = mesos::internal::tests::Module > [ RUN ] MasterAllocatorTest/1.SlaveLost > [ OK ] MasterAllocatorTest/1.SlaveLost (120 ms) > [----------] 1 test from MasterAllocatorTest/1 (120 ms total) > ``` > > > Thanks, > > Shuai Lin > >