From reviews-return-30346-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 8 14:03:11 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5756D1977F for ; Fri, 8 Apr 2016 14:03:11 +0000 (UTC) Received: (qmail 78154 invoked by uid 500); 8 Apr 2016 14:03:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 78126 invoked by uid 500); 8 Apr 2016 14:03:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 78113 invoked by uid 99); 8 Apr 2016 14:03:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 14:03:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EC6B21D364A; Fri, 8 Apr 2016 14:03:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1706181012971127242==" MIME-Version: 1.0 Subject: Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test. From: Alexander Rukletsov To: Alexander Rukletsov Cc: Shuai Lin , mesos Date: Fri, 08 Apr 2016 14:03:07 -0000 Message-ID: <20160408140307.20106.36162@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43329/ X-Sender: Alexander Rukletsov X-ReviewBoard-ShipIt: 1 References: <20160330132219.5121.71835@reviews.apache.org> In-Reply-To: <20160330132219.5121.71835@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============1706181012971127242== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43329/#review127783 ----------------------------------------------------------- Fix it, then Ship it! Could you please run tests in repetition? Thanks! src/tests/master_allocator_tests.cpp (line 652) I think it's fine to do this, but let's explain why we adjust the flag. - Alexander Rukletsov On March 30, 2016, 1:22 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43329/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 1:22 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-3775 > https://issues.apache.org/jira/browse/MESOS-3775 > > > Repository: mesos > > > Description > ------- > > Speeded up MasterAllocatorTest.SlaveLost test. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 > > Diff: https://reviews.apache.org/r/43329/diff/ > > > Testing > ------- > > ``` > [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator torProcess > > [ RUN ] MasterAllocatorTest/0.SlaveLost > [ OK ] MasterAllocatorTest/0.SlaveLost (369 ms) > [----------] 1 test from MasterAllocatorTest/0 (369 ms total) > > [----------] 1 test from MasterAllocatorTest/1, where TypeParam = mesos::internal::tests::Module > [ RUN ] MasterAllocatorTest/1.SlaveLost > [ OK ] MasterAllocatorTest/1.SlaveLost (120 ms) > [----------] 1 test from MasterAllocatorTest/1 (120 ms total) > ``` > > > Thanks, > > Shuai Lin > > --===============1706181012971127242==--