From reviews-return-30281-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 7 21:22:54 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92867195E6 for ; Thu, 7 Apr 2016 21:22:54 +0000 (UTC) Received: (qmail 66216 invoked by uid 500); 7 Apr 2016 21:22:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 66183 invoked by uid 500); 7 Apr 2016 21:22:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 66166 invoked by uid 99); 7 Apr 2016 21:22:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Apr 2016 21:22:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 060F02AD106; Thu, 7 Apr 2016 21:22:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7309762478755684195==" MIME-Version: 1.0 Subject: Re: Review Request 45440: Added some metrics to the long-lived-framework example. From: Vinod Kone To: Kevin Klues , Artem Harutyunyan , Vinod Kone , Greg Mann Cc: Mesos ReviewBot , Joseph Wu , mesos Date: Thu, 07 Apr 2016 21:22:51 -0000 Message-ID: <20160407212251.20107.65710@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45440/ X-Sender: Vinod Kone References: <20160406185553.20106.51758@reviews.apache.org> In-Reply-To: <20160406185553.20106.51758@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============7309762478755684195== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 6, 2016, 6:55 p.m., Vinod Kone wrote: > > As discussed offline, lets add TODOs for metrics to defer the gauges to scheduler process. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127404 ----------------------------------------------------------- On April 6, 2016, 11:19 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45440/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 11:19 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-5062 > https://issues.apache.org/jira/browse/MESOS-5062 > > > Repository: mesos > > > Description > ------- > > Adds metrics to gauge the health of the framework. This includes: > > * uptime_secs = How long the framework has been running. > * registered = If the framework is registered. > * offers_received = A counter used to determine if the framework is > starved or not. > * tasks_launched = Number of tasks launched. > * abnormal_terminations = Number of terminal status updates which > were not `TASK_FINISHED`. > > Also adds an endpoint `/framework/counters` which returns the list of > metrics which are "counters". > > > Diffs > ----- > > src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 > > Diff: https://reviews.apache.org/r/45440/diff/ > > > Testing > ------- > > make check > > Also deployed this version on a test cluster. See the previous review. > > > Thanks, > > Joseph Wu > > --===============7309762478755684195==--