mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pangbingqiang <pangbingqi...@huawei.com>
Subject 答复: Review Request 46249: Hook and module process operation before main process initialize.
Date Fri, 22 Apr 2016 01:45:12 GMT
OK,I have post review request, thanks.

发件人: Vinod Kone [mailto:noreply@reviews.apache.org] 代表 Vinod Kone
发送时间: 2016年4月22日 8:37
收件人: Kapil Arya; Niklas Nielsen; Adam B; Joseph Wu; Vinod Kone
抄送: pangbingqiang; mesos
主题: Re: Review Request 46249: Hook and module process operation before main process initialize.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/




Committed this. But can you send another review for slave/main.cpp as well?


- Vinod Kone


On April 19th, 2016, 2:52 a.m. UTC, Andy Pang wrote:
Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and Vinod Kone.
By Andy Pang.

Updated April 19, 2016, 2:52 a.m.
Repository: mesos
Description

If we in hook/module manager use libprocess library,

it will auto use process initialize fucntion,

as the process::initialize will only call once,

then in the main fucnton process initialize


process::initialize("master") will not be called.

So the HTTP request process "delegate" will be wrong,

http request will not be response.


Testing

make check


Diffs

  *   src/master/main.cpp (7bbc982)

View Diff<https://reviews.apache.org/r/46249/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message