mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 46730: Cleanup syscalls logic.
Date Sat, 30 Apr 2016 18:06:55 GMT


> On Kwi 30, 2016, 2:55 po południu, haosdent huang wrote:
> > As I checked with @bingli1000 and @zhiwei via email before, this works in powerpc
and IBM System z. Free feel to list your concerns about test :-). cc @bmahler and @janisz
> 
> haosdent huang wrote:
>     By the way, I think the `Summary` is not clear and exactly. I think need to rephrase
it when submit it.

How about 
- summary:

> Cleanup platform specific syscall conditions. 

- description:

> Use syscall defines from `<linux/unistd.h>` instead of glibc to handle different
platforms without platform conditions.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131253
-----------------------------------------------------------


On Kwi 29, 2016, 1:03 po południu, Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated Kwi 29, 2016, 1:03 po południu)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message