mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46814: Refactored FlagsBase::load().
Date Sat, 30 Apr 2016 01:59:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/
-----------------------------------------------------------

(Updated April 30, 2016, 1:59 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
-------

mpark's comments.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

Made this function more readable. The error strings are still kept the
same as the previous code.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21


Diff: https://reviews.apache.org/r/46814/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message