mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 46779: Clarified and improved maintenance docs.
Date Fri, 29 Apr 2016 22:02:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46779/#review131187
-----------------------------------------------------------


Fix it, then Ship it!




Some suggestions below:


docs/maintenance.md (line 184)
<https://reviews.apache.org/r/46779/#comment195100>

    s/their/the machine's/



docs/maintenance.md (line 188)
<https://reviews.apache.org/r/46779/#comment195102>

    s/Inverse offers/Inverse offers are also used to/



docs/maintenance.md (lines 260 - 264)
<https://reviews.apache.org/r/46779/#comment195118>

    I would put this paragraph in a `>NOTE:`


- Joseph Wu


On April 28, 2016, 7:53 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46779/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 7:53 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clarified and improved maintenance docs.
> 
> 
> Diffs
> -----
> 
>   docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 
> 
> Diff: https://reviews.apache.org/r/46779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message