mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46806: Fixed and illustrated process::initialize ordering.
Date Fri, 29 Apr 2016 16:32:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/#review131120
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Joseph! LGTM, modulo Joerg's comments and another small one below.


3rdparty/libprocess/src/process.cpp (line 989)
<https://reviews.apache.org/r/46806/#comment195064>

    I'm guessing this refers to `new Route("/__processes__", None(), __processes__);`? I think
it might be helpful to use a more obvious name. Or perhaps referencing the `process_route`
name in a comment above the `Route()` statement would do the trick?


- Greg Mann


On April 28, 2016, 11:58 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46806/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Bugs: MESOS-5304
>     https://issues.apache.org/jira/browse/MESOS-5304
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moves `metrics::initialize` below the creation of the `help` process.
> 
> Adds a comment block to explain the ordering of process creation in 
> `process::initialize`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46806/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message