mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 46792: Parameterized agent authorization tests by endpoint.
Date Fri, 29 Apr 2016 14:07:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46792/#review131098
-----------------------------------------------------------




src/tests/slave_authorization_tests.cpp (lines 82 - 87)
<https://reviews.apache.org/r/46792/#comment195051>

    We only really need the MockAuthorizer in the positive authz test, to see that the right
request was used. In all of the other tests we know that implicitly, because we receive a
`Forbidden`. How about we enhance `MockAuthorizer` to act as a proxy for the underlying authorizer,
similar to how it's done for `MockDocker`? We would then only need a single test fixture because
the whole pipeline as well as the correct calls to the authorizer could be cover in its test
cases.


- Jan Schlicht


On April 28, 2016, 7:24 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46792/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, only '/flags' endpoint is being tested by the
> `SlaveAuthorizationTest` test fixture. However, the same
> tests can be applied to any endpoint that consults
> authorizer for GET requests.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp d3ab0835c8d2464a65f382087d914412dc573b44 
> 
> Diff: https://reviews.apache.org/r/46792/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `make check`
> `GTEST_FILTER="*SlaveEndpointTest*:*SlaveAuthorizationTest*" ./bin/mesos-tests.sh --gtest_repeat=100
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message