mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 46730: Cleanup syscalls logic.
Date Fri, 29 Apr 2016 13:01:20 GMT


> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > Could you also update the testing section? How did you ensure this compiles on the
affected architectures?

What do you mean by "testing section"? Unfortunatelly I've only tested it on ARM and x86_64


> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/ns.hpp, lines 161-162
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363200#file1363200line161>
> >
> >     This looks like a similar change but it would be great to split it into a separate
patch. It's not immediately obvious to me why `SYS_setns` is being changed in favor of `__NR_setns`.
Can you add some some background information in the review description?
> 
> haosdent huang wrote:
>     +1 For only change `__NR_pivot_root` and update `__NR_setns` in a separate patch.
I think why @janisz update to `__NR_setns` here is because he want to keep consistent as he
mentioned above.

`SYS_setns` comes from glibc I (and in fact it's map for `__NR_setns`) becouse I see condition
for old glibc and thought it could be replaced with kernel macro. Reverted my change


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message