mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 46730: Cleanup syscalls logic.
Date Fri, 29 Apr 2016 10:52:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131077
-----------------------------------------------------------




src/linux/cgroups.cpp 
<https://reviews.apache.org/r/46730/#comment195029>

    May you revert the changes in `cgroups.cpp` as well, we could do this in a sperate patch.
In additional, we need update the `Summary` and `Description` to make them more excactly.


- haosdent huang


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message