mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
Date Fri, 29 Apr 2016 08:31:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131058
-----------------------------------------------------------



This target will not be removed until the term 'slave' is completely removed in the code,
I'm ok to the change

- zhou xing


On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> -----------------------------------------------------------
> 
> (Updated 四月 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> -------
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use
relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of not, since
MESOS-3782 & MESOS-5230 already completed. This blocked our daily build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message