mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46669: Added deprecation support to Flag name.
Date Fri, 29 Apr 2016 03:28:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------

(Updated April 29, 2016, 3:28 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
-------

Ben's comments.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

Added deprecation support to Flag name.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21

  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc


Diff: https://reviews.apache.org/r/46669/diff/


Testing
-------

Tested manually by running ./bin/mesos-master.sh --authenticate

The one caveat is that the deprecation warning might be printed before logging the library
is initialized (e.g., master/main.cpp calls flags.load() before logging::initialize(flags)).


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message