mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 45961: Support sharing of resources through reference counting of resources.
Date Fri, 29 Apr 2016 00:16:32 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 29, 2016, 12:16 a.m.)

Review request for mesos and Jiang Yan Xu.


Refactored based on changes in public APIs in `Resource_`.

Bugs: MESOS-4431

Repository: mesos


Number of consumers for each shared resource is tracked. The count is
incremented on task launch, and decremented on task termination whenever
the task uses a shared resource.
Allow DESTROY for shared volumes only if reference count is 0.
Since shared resources are available to multiple frameworks of the
same role simultaneously, we normalize it with a weight equivalent
to the number of frameworks to which this shared resource has been
allocated to in the sorter.

Diffs (updated)

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.hpp 2840f459288bbe8440eda08119d4f86a8be5a291 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.cpp 0de03c7347e01fde2b42f5ec38a34a62edf642a1 
  src/master/allocator/sorter/drf/sorter.hpp 05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d 
  src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 



Tests successful.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message