mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46373: Request /files/read.json with a negative length value causes error.
Date Wed, 27 Apr 2016 23:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review130864
-----------------------------------------------------------


Fix it, then Ship it!




Looks great! Just a couple small comments below, and then I think it's ready for BenM to have
a look.


src/files/files.cpp (line 463)
<https://reviews.apache.org/r/46373/#comment194774>

    Now that `length` is a `size_t`, we can get rid of the `static_cast` here.



src/tests/files_tests.cpp (line 175)
<https://reviews.apache.org/r/46373/#comment194769>

    End comment with a period.



src/tests/files_tests.cpp (line 183)
<https://reviews.apache.org/r/46373/#comment194770>

    End comment with a period.


- Greg Mann


On April 26, 2016, 8:15 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
>     https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message