mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.
Date Tue, 26 Apr 2016 19:08:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review130664
-----------------------------------------------------------



Can you make the description more descriptive please? Make it clear what the change is here.
Also, no need for including bug-id in the description. It is already attached to the review.


CHANGELOG (line 76)
<https://reviews.apache.org/r/46676/#comment194497>

    "Slave/Agent" is correct. The earlier ones called it "Replace Master/Slave Terminology".
Can you fix the earlier ones? You need to fix the name of the actual tickets in the JIRA and
also this changelog. Please send a separate review for the CHANGELOG.



src/Makefile.am (line 535)
<https://reviews.apache.org/r/46676/#comment194499>

    what does setting this variable do?



src/Makefile.am (line 2144)
<https://reviews.apache.org/r/46676/#comment194498>

    Update the comment.



src/Makefile.am (lines 2151 - 2152)
<https://reviews.apache.org/r/46676/#comment194501>

    IIUC, when someone does a  `make install` there will be 2 directories in the installation
directory.
    
    ...../mesos/agent
    ...../mesos/slave  (this is a symlink to ../agent)
    
    In the git repo itself we will still have `include/mesos/slave` directory? I guess renaming
this directory to `incluee/mesos/agent`? is too much work?


- Vinod Kone


On April 26, 2016, 6:06 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
>     https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [#MESOS-5230]
> Change the 'make install' includedir name from slave to agent.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> -------
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message