mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 46203: Added authorization of the '/flags' endpoint.
Date Tue, 26 Apr 2016 11:13:14 GMT


> On April 26, 2016, 8:27 a.m., Adam B wrote:
> > src/slave/http.cpp, line 360
> > <https://reviews.apache.org/r/46203/diff/13/?file=1359473#file1359473line360>
> >
> >     Should this perhaps be a `Shared<>`?
> 
> Jan Schlicht wrote:
>     I don't think so. `Shared<>` is about shared ownership, but the closure shouldn't
own `Slave*`, but only use it. If we'd want to make sure that `slave_ != NULL` during the
lifetime of the closure, we would have to use something like `std::weak_ptr`, managed by a
shared pointer.
>     I'd argue that because the `Slave` instance routes its HTTP requests to an `Http`
instance, `slave_ != NULL` during the lifetime of the `Http` instance. Hence it's safe to
use the pointer to `Slave` in the closure.
>     
>     Anyways, I'll change the closure to use `Flags` instead of `Slave*` as a parameter.
The will be copied by value, object lifetime isn't a problem in that case.

Can we drop this?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46203/#review130538
-----------------------------------------------------------


On April 26, 2016, 1:10 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46203/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 1:10 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5142
>     https://issues.apache.org/jira/browse/MESOS-5142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 318275fc5f935e6992ed4e8048cc4b42cc5d2cab 
>   include/mesos/authorizer/acls.proto c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 
>   include/mesos/authorizer/authorizer.proto 40d93ea257d1df8d22eee8a21667db90d579a8fe

>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
>   src/authorizer/local/authorizer.cpp 0a3805fe4ce8eb89e096e8cd4326035513ba892b 
>   src/slave/flags.cpp a319d60c006d1104836c1c40f3617ceac9cb7b1e 
>   src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 
>   src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46203/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message