mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Larriba <jlarr...@gmail.com>
Subject Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.
Date Tue, 26 Apr 2016 07:36:44 GMT


> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote:
> > support/docker_build.sh, lines 127-140
> > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line127>
> >
> >     Hmm. I was hoping for something more generic than hard coding these 3 configurations.
But if it's not easy to auto translate and the configuration options for CMAKE are truly different
from Autotools, I'm ok with not doing this change here and instead have 2 different Jenkins
jobs (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping we could get
away with having just one Jenkins job (parameterized).
> 
> Juan Larriba wrote:
>     I will try to submit a more generic proposal to convert from autotools to cmake parameters
so the same Jenkins job can be used for building, I have had a lot of work this past week
and couldn't do anything. However, I still do not understand why the BUILDTOOL or the COMPILER
parameters can change between job executions and the CONFIGURATION parameter cannot change
at the same time.
> 
> Vinod Kone wrote:
>     The ASF CI job is setup as a paremeterized job (https://builds.apache.org/view/M-R/view/Mesos/job/Mesos/).
The parameters are the environment varialbes (BUILDTOOL, COMPILER, CONFIGURATION etc). So
all the combinations of the environmental varialbles should work.
>     
>     For example if we have the following envs,
>     
>     BUILDTOOL = "'autotools' 'cmake'"
>     COMPILER = "'gcc' 'clang'"
>     CONFIGURATION = "'--verbose' '--enable_libevent'"
>     
>     Then all the combinations of these should work.
>     
>     autotools x gcc x --verbose
>     autotools x gcc x --enable_libevent
>     autotools x clang x --verbose
>     autotools x clang x --enable_libevent
>     cmake x gcc x --verbose
>     cmake x gcc x --enable_libevent
>     cmake x clang x --verbose
>     cmake x clang x --enable_libevent
>     
>     Hope this makes sense?

Thank you very much Vinod, now it makes sense

The fact is that I do not have permissions to see the internals of the job (the link you pasted),
so I couldn't figure out how the build was being executed. I will submit the modifications
needed to convert from autotools CONFIGURATION to cmake CONFIGURATION.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129387
-----------------------------------------------------------


On Abr. 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools.
In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message