mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.
Date Tue, 26 Apr 2016 06:31:26 GMT


> On April 22, 2016, 1:22 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, line 1895
> > <https://reviews.apache.org/r/46319/diff/2/?file=1348483#file1348483line1895>
> >
> >     Should we create a TYPED_TEST that tests this ACL in the local authorizer (direct
and as a module), or do we only need these tests for one (of the many) ACCESS_ENDPOINT_WITH_PATH
endpoints?
> 
> Benjamin Bannier wrote:
>     I would prefer if we'd separate whether some authorizer works and whether an endpoint
correctly queries the authorizer. You already suggested testing the former to Jan [here](https://reviews.apache.org/r/46203/#comment193252);
how about I migrate the current test to a *parameterized test* (on the endpoint) so we have
a single infrastructure to check authorization for all `GET` requests against agent endpoints?
Once we start tackling e.g., `POST` requests we could extend this harness.
>     
>     I made this test parameterized on the agent endpoint in https://reviews.apache.org/r/46569/;
if we'd want to go that direction we could squash it into this patch.

Sounds great. Feel free to squash r/46569 into this patch or leave it separate.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46319/#review130057
-----------------------------------------------------------


On April 25, 2016, 7:16 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46319/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 7:16 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization to agents' `/monitor/statistics` endpoints.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 
>   src/slave/slave.hpp 20a4bcd0bb9dad06ea81fc4ad9b2fa462c69d2c5 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46319/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message