mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.
Date Tue, 26 Apr 2016 00:54:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
-----------------------------------------------------------

(Updated April 26, 2016, 12:54 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Used stringify(name) instead of name.value in string concatenations.


Bugs: MESOS-5271
    https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
-------

This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21


Diff: https://reviews.apache.org/r/46620/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message