mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 46588: Added URI struct to stout.
Date Mon, 25 Apr 2016 23:13:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/
-----------------------------------------------------------

(Updated April 25, 2016, 4:13 p.m.)


Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.


Changes
-------

Add roundtrip equality to the test.  Handle some nuances in the "path" part of the URI.


Bugs: MESOS-5254
    https://issues.apache.org/jira/browse/MESOS-5254


Repository: mesos


Description
-------

This will replace the `mesos::URI` protobuf currently used by the 
`uri::Fetcher`.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 08ede41dcedc755933d656de58d93796e657749d

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721

  3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46588/diff/


Testing
-------

make check (OSX) GTEST_FILTER="URITest*"


Ran a clean build (make check) on:

* Ubuntu 12, 14, 15
* CentOS 6, 7
* Debian 8


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message