mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Mon, 25 Apr 2016 22:55:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review130502
-----------------------------------------------------------



Some inline TODO's from an offline review (with Joris & Neil).


3rdparty/libprocess/src/process.cpp (lines 781 - 788)
<https://reviews.apache.org/r/40266/#comment194261>

    Write a test for this.  i.e. Try to connect to this socket (with plain sockets) while
`process::finalize` is running.



3rdparty/libprocess/src/process.cpp (line 1106)
<https://reviews.apache.org/r/40266/#comment194257>

    Consider moving to `::finalize`.  The unproxy code should mostly remain in-place.



3rdparty/libprocess/src/process.cpp (lines 2036 - 2040)
<https://reviews.apache.org/r/40266/#comment194259>

    Save `PID` and terminate via `PID`.  This is a better guarantee against asynchronous/multiple
termination events.



3rdparty/libprocess/src/process.cpp (line 2279)
<https://reviews.apache.org/r/40266/#comment194260>

    Rename to something that doesn't semantically collide with `process::finalize`.  Not as
explicit as `clean_up_all_but_gc()`, but along those lines.


- Joseph Wu


On April 14, 2016, 1:28 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 1:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3910
>     https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `SocketManager` and `ProcessManager` are highly inter-dependent, 
> which requires some untangling in `process::finalize`.
> 
> * Logic originally found in `~ProcessManager` has been split into 
>   `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as 
>   libevent does not detect a locally closed socket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739 
> 
> Diff: https://reviews.apache.org/r/40266/diff/
> 
> 
> Testing
> -------
> 
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message