mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.
Date Mon, 25 Apr 2016 20:45:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40512/#review130500
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp (line 475)
<https://reviews.apache.org/r/40512/#comment194253>

    Typo.


- Neil Conway


On April 14, 2016, 8:28 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40512/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3820
>     https://issues.apache.org/jira/browse/MESOS-3820
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This builds upon earlier changes to complete `process::finalize`.  
> Tests which need to reconfigure libprocess, such as some SSL-related 
> tests, can use `process::reinitialize` to do so.  
> 
> This method may also be useful for providing additional isolation 
> between tests, such as cleaning up all processes after each test case.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp 523b9740a45bdae3fa9a1a1423108e6815fbf872 
>   3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739 
> 
> Diff: https://reviews.apache.org/r/40512/diff/
> 
> 
> Testing
> -------
> 
> Defined `process::reinitialize` in several tests, such as `HTTPTest`, `MetricsTest`,
and `ReapTest` can called `process::reinitialize` before and after tests.  Confirmed that
this did not have side effects on other tests (See https://reviews.apache.org/r/40453/ ).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message