mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.
Date Mon, 25 Apr 2016 17:37:48 GMT


> On April 25, 2016, 3:32 p.m., Kapil Arya wrote:
> > src/tests/metrics_tests.cpp, line 85
> > <https://reviews.apache.org/r/46261/diff/3/?file=1355178#file1355178line85>
> >
> >     Newline?

Good catch! Fixed.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46261/#review130425
-----------------------------------------------------------


On April 25, 2016, 5:37 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46261/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:37 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The tests `MetricsTest.AgentAuthenticationEnabled` and
> `MetricsTest.MasterAuthenticationEnabled` are added in
> this patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 
> 
> Diff: https://reviews.apache.org/r/46261/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message