mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).
Date Mon, 25 Apr 2016 17:27:01 GMT


> On April 25, 2016, 4:01 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/configure.ac, line 853
> > <https://reviews.apache.org/r/46461/diff/2/?file=1355117#file1355117line853>
> >
> >     I am wondering if we should split out this patch into two: one that updates
bundled version, and second that does the HAS_GPERTOOL->ENABLE_GPERFTOOLS transition.

Good call; I split off a second review here: https://reviews.apache.org/r/46643/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130436
-----------------------------------------------------------


On April 25, 2016, 5:25 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46461/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-3319
>     https://issues.apache.org/jira/browse/MESOS-3319
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated gperftools to version 2.5 (libprocess).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf

>   3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 5506eb3 
> 
> Diff: https://reviews.apache.org/r/46461/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message