mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 46593: Added test for containerizer destroy while provisioning race.
Date Mon, 25 Apr 2016 14:24:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46593/#review130418
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/mesos_containerizer_tests.cpp (line 958)
<https://reviews.apache.org/r/46593/#comment194160>

    Extra set of parentheses here doesn't seem useful. (Can you fix this where it occurs elsewhere
in the test file?)


- Neil Conway


On April 22, 2016, 11:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46593/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for containerizer destroy while provisioning race.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce

> 
> Diff: https://reviews.apache.org/r/46593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified that the test is 90% chance to be segfault if we reverted the fix.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message