mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.
Date Mon, 25 Apr 2016 14:02:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 25, 2016, 2:02 p.m.)

Review request for mesos, Alexander Rojas and Kapil Arya.


Addressed comments.

Bugs: MESOS-4902

Repository: mesos


Added authentication to the '/profiler/*' endpoints.

Diffs (updated)

  3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab

  3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
  3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 


Testing (updated)

`sudo make check` on OSX. The endpoints were also tested by configuring with `../configure
--enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER`
environment variable set to 1.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message