mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46564: Fixed a typo in Docker containerizer.
Date Mon, 25 Apr 2016 08:17:43 GMT


> On April 25, 2016, 9:48 a.m., Timothy Chen wrote:
> > Can you rebase your patch? Thanks!
> 
> Qian Zhang wrote:
>     Sorry, I do not quite understand. I think the file I updated in this patch was not
updated by others after I posted this patch, so there should be no conflict, right? :-)
> 
> Timothy Chen wrote:
>     I tried to apply it on latest master but it has conflict, so you need to rebase on
the latest master and update the patch again.

OK, I have rebased on the latest master, but it seems the updated patch is same with the previous
one.

BTW, can you please help review https://reviews.apache.org/r/46264/? It is also a simple fix
to a typo :-)


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46564/#review130341
-----------------------------------------------------------


On April 25, 2016, 4:15 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46564/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 4:15 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a typo in Docker containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 30f85a13f70fc2b1e04dbf0ca7f47bff806e4672 
> 
> Diff: https://reviews.apache.org/r/46564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message