mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).
Date Mon, 25 Apr 2016 06:41:45 GMT


> On April 18, 2016, 5:03 p.m., Ben Mahler wrote:
> > src/authorizer/local/authorizer.cpp, line 204
> > <https://reviews.apache.org/r/45342/diff/2/?file=1317428#file1317428line204>
> >
> >     We generally avoid 'default' cases in enum switches because they allow the code
to compile when a new enum value is introduced.
> >     
> >     If you use a 'case UNKNOWN' instead, this will handle the unknown types and
will prevent the code from compiling when a new enum value is introduced but not handled.
> >     
> >     Make sense?
> >     
> >     Ditto for the recent executor.proto and scheduler.proto changes.

Fixed in https://reviews.apache.org/r/46470/
See also https://reviews.apache.org/r/46364/


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45342/#review129450
-----------------------------------------------------------


On March 28, 2016, 7:04 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45342/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Bugs: MESOS-5031
>     https://issues.apache.org/jira/browse/MESOS-5031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix tries to make the Action enum in Authorization optional
> to support upgrades. See MESOS-4997 for details.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 944a493e0979c7ffbd99f3a67785a10425fd9040

>   src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650 
> 
> Diff: https://reviews.apache.org/r/45342/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message