mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 46580: Added uriparser as a bundled dependency.
Date Sat, 23 Apr 2016 00:42:06 GMT


> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/configure.ac, line 892
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357691#file1357691line892>
> >
> >     Is this some specicial autoconf thing? I don't see it being used...

Oops, that's a leftover from a more rigorous check I was considering.  (i.e. checking the
version of `uriparser`)  Forgot to remove it when I just opted to check the header.


> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/Makefile.am, lines 189-191
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357690#file1357690line189>
> >
> >     Not yours, but I don't know why those are needed.

Hmm... yeah, these shouldn't be necessary with these lines (143-147) in the same file:
```
libprocess_la_LIBADD =			\
  $(LIBGLOG)				\
  $(HTTP_PARSER_LIB)			\
  $(EVENT_LIB)				\
  $(LIBURIPARSER)
```


> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 74
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357687#file1357687line74>
> >
> >     Can you fix the tailing `\` alignment?

Added a tab (to that blob), so that the backslashes line up with the other ones in the file.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/#review130179
-----------------------------------------------------------


On April 22, 2016, 12:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46580/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
> 
> 
> Bugs: MESOS-5254
>     https://issues.apache.org/jira/browse/MESOS-5254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am f7aa579 
>   3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 5506eb3 
>   3rdparty/libprocess/Makefile.am c51c31e 
>   3rdparty/libprocess/configure.ac d27e46e 
> 
> Diff: https://reviews.apache.org/r/46580/diff/
> 
> 
> Testing
> -------
> 
> ../configure
> make
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message