mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46588: Added URI struct to stout.
Date Sat, 23 Apr 2016 00:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46588/#review130232
-----------------------------------------------------------



Bad patch!

Reviews applied: [46588, 46580]

Failed command: ./support/apply-review.sh -n -r 46588

Error:
2016-04-23 00:39:55 URL:https://reviews.apache.org/r/46588/diff/raw/ [9453/9453] -> "46588.patch"
[1]
Total errors found: 0
Checking 2 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12678/console

- Mesos ReviewBot


On April 22, 2016, 11:39 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46588/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 11:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will replace the `mesos::URI` protobuf currently used by the `uri::Fetcher`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 33ddb06e25920096f2d16d4f372129ee2f6a8721

>   3rdparty/libprocess/3rdparty/stout/include/stout/uri.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/uri_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46588/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX) GTEST_FILTER="URITest*"
> 
> TODO: Run build on a clean environment.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message