mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46504: Constructed error string in MethodNotAllowed.
Date Fri, 22 Apr 2016 19:31:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46504/#review130103
-----------------------------------------------------------



For posterity, could you please explain a bit in the description what you intention here is
and why you take this implemntation approach?


3rdparty/libprocess/include/process/http.hpp (lines 569 - 571)
<https://reviews.apache.org/r/46504/#comment193770>

    We usually insert two blank lines here.



3rdparty/libprocess/include/process/http.hpp (line 571)
<https://reviews.apache.org/r/46504/#comment193771>

    Does it make sense to declare this struct inside `MethodNotAllowed`?



3rdparty/libprocess/include/process/http.hpp (lines 573 - 574)
<https://reviews.apache.org/r/46504/#comment193774>

    It looks like you don't need to keep this two valus as fields, right?



3rdparty/libprocess/include/process/http.hpp (line 579)
<https://reviews.apache.org/r/46504/#comment193773>

    Why do you take `Request` instead of a method?



3rdparty/libprocess/include/process/http.hpp (lines 603 - 605)
<https://reviews.apache.org/r/46504/#comment193769>

    We usually insert two blank lines here.



3rdparty/libprocess/include/process/http.hpp (lines 623 - 624)
<https://reviews.apache.org/r/46504/#comment193768>

    Blank line, please!



3rdparty/libprocess/include/process/http.hpp 
<https://reviews.apache.org/r/46504/#comment193767>

    Why have you removed this line?


- Alexander Rukletsov


On April 22, 2016, 3:11 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46504/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4126
>     https://issues.apache.org/jira/browse/MESOS-4126
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297

> 
> Diff: https://reviews.apache.org/r/46504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message