mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 46551: Experimental: Use liburiparser to parse URIs.
Date Fri, 22 Apr 2016 19:24:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46551/
-----------------------------------------------------------

(Updated April 22, 2016, 12:24 p.m.)


Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.


Changes
-------

Changed uriparser to a bundled dependency (see dependent review).


Bugs: MESOS-5254
    https://issues.apache.org/jira/browse/MESOS-5254


Repository: mesos


Description (updated)
-------

This demonstrates what it might look like to use `uriparser` to replace 
the implementation of `http::URL::parse`.

WIP: We want to use `uriparser` to parse a URI (not a URL).


Diffs (updated)
-----

  3rdparty/libprocess/src/http.cpp 48f91d01555e760b1c4fd2cde684168d65f75e57 
  3rdparty/libprocess/src/tests/http_tests.cpp 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a 

Diff: https://reviews.apache.org/r/46551/diff/


Testing
-------

make check GTEST_FILTER="*ParseUrls"


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message