mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.
Date Fri, 22 Apr 2016 14:36:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46491/
-----------------------------------------------------------

(Updated April 22, 2016, 2:36 p.m.)


Review request for mesos, Benjamin Bannier and Ben Mahler.


Bugs: MESOS-5240
    https://issues.apache.org/jira/browse/MESOS-5240


Repository: mesos


Description
-------

In command executor, capture the state when a task is killed (i.e.,
reaped) in a flag and use this flag to prevent calls to `killTask()`
and `escalated()` when they are executed after the task is killed.


Diffs (updated)
-----

  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/http_command_executor.cpp 2ce296740abac096aa85ad11dd4d191e42c1aa06 

Diff: https://reviews.apache.org/r/46491/diff/


Testing
-------

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message